Summary

This PR converts all remaining pytest parametrized tests to use NamedTuple fixtures instead of raw tuples. This improves test readability, maintainability, and type safety.

Changes

Converted all parametrized tests to use NamedTuple fixtures:

test_cli.py

• Added HelpTestFixture for help command tests
  • Converted test_help to use named parameters

test_convert.py

• Added ConvertTestFixture for YAML conversion tests
  • Converted test_convert to use named parameters
• Added ConvertJsonTestFixture for JSON conversion tests
  • Converted test_convert_json to use named parameters

test_freeze.py

• Added FreezeTestFixture for freeze command tests
  • Converted test_freeze to use named parameters
• Added FreezeOverwriteTestFixture for force overwrite tests
  • Converted test_freeze_overwrite to use named parameters

test_import.py

• Added ImportTestFixture for basic import tests
  • Converted test_import to use named parameters
• Added ImportTeamocilTestFixture for teamocil import tests
  • Converted test_import_teamocil to use named parameters
• Added ImportTmuxinatorTestFixture for tmuxinator import tests
  • Converted test_import_tmuxinator to use named parameters

test_load.py

• Added ZshAutotitleTestFixture for ZSH auto title warning tests
  • Converted test_load_zsh_autotitle_warning to use named parameters
• Added LogFileTestFixture for log file tests
  • Converted test_load_log_file to use named parameters
• Added PluginVersionTestFixture for plugin version tests
  • Converted test_load_plugins_version_fail_skip to use named parameters
  • Converted test_load_plugins_version_fail_no_skip to use named parameters
• Added PluginMissingTestFixture for missing plugin tests
  • Converted test_load_plugins_plugin_missing to use named parameters

Each conversion includes:

1. New NamedTuple class with docstring
2. Test fixture list with descriptive test IDs
3. Updated parametrize decorator to use NamedTuple fields
4. Added test_id parameter to test function signature
5. Improved test case documentation through fixture names and test IDs

Benefits

1. Improved Type Safety: NamedTuples provide type hints for test parameters, making it easier to catch type-related issues
2. Better Test Documentation: Each fixture class includes a docstring explaining its purpose
3. More Maintainable Tests: Parameters are accessed by name rather than position, reducing the chance of errors when modifying tests
4. Clearer Test IDs: Each test case has a descriptive ID, making test failures easier to understand
5. Consistent Style: Aligns with existing NamedTuple fixtures used elsewhere in the codebase

Example

Before:

@pytest.mark.parametrize(
    "cli_args",
    [["--help"], ["-h"]],
)
def test_help(cli_args: list[str], ...):

After:

class HelpTestFixture(t.NamedTuple):
    """Test fixture for help command tests."""
    test_id: str
    cli_args: list[str]

HELP_TEST_FIXTURES = [
    HelpTestFixture(
        test_id="help_long_flag",
        cli_args=["--help"],
    ),
    HelpTestFixture(
        test_id="help_short_flag",
        cli_args=["-h"],
    ),
]

@pytest.mark.parametrize(
    list(HelpTestFixture._fields),
    HELP_TEST_FIXTURES,
    ids=[test.test_id for test in HELP_TEST_FIXTURES],
)
def test_help(test_id: str, cli_args: list[str], ...):

Testing

• All existing tests continue to pass
• No functional changes - this is purely a refactoring of test structure
• Each test file has been verified to maintain the same test coverage

Related

Continues the work of standardizing test fixtures across the codebase, following the pattern established in files like test_builder.py and test_shell.py.

Summary by Sourcery

Refactor existing parametrized tests to use NamedTuple test fixtures, improving readability and maintainability. Add tests for missing scenarios like nonexistent targets and interactive shell in shell command tests. Parametrize workspace finder tests to cover various path scenarios and workspace load tests to cover different enter and sleep behaviors.

Tests:

• Improve test parametrization by creating reusable test fixtures for shell command tests, teamocil, tmuxinator config import tests, and workspace load tests.
• Add tests for missing scenarios like nonexistent targets and interactive shell in shell command tests.
• Parametrize workspace finder tests to cover various path scenarios.
• Parametrize workspace load tests to cover different enter and sleep behaviors.